fix(mmds): Set Content-Type header correctly #5226
Merged
+148
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulinx86
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
zulinx86
added
the
Status: Awaiting review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5226 +/- ##
==========================================
+ Coverage 82.88% 82.94% +0.06%
==========================================
Files 250 250
Lines 26942 26965 +23
==========================================
+ Hits 22330 22367 +37
+ Misses 4612 4598 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pb8o
reviewed
May 28, 2025
roypat
reviewed
May 28, 2025
zulinx86
force-pushed
the
mmds_fix
branch
2 times, most recently
from
55329c6 to
b0e7464
Compare
The MMDS response "Content-Type" header was always "application/json" regardless of the request "Accept" header, although MMDS responds different contents depending on the "Accept" header. Without "Accept" header or with empty "Accept:" or "Accept: */*", micro-http defaults to "Accept: text/plain". In such a case, MMDS behaves like IMDS and the response content is plain text, so "Content-Type" should be "text/plain". Signed-off-by: Takahiro Itazuri <[email protected]>
test_get_value() lacked coverage for strings. Instead of merely adding a normal string test, adds a test for a string including escapes. Signed-off-by: Takahiro Itazuri <[email protected]>
pb8o
approved these changes
May 28, 2025
roypat
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See CHANGELOG
Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
CHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
integration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.